I think a lot of it is reletive really.
Many people buy ex-mil gear because it's usually well made & time proven in terms of both quality & functionality.
It's also fairly readilly available at reasonable cost.
For many years I resisted wearing camo as I din't want to get lumped in with the 'Urban Soldier' ****ers.
However, I do now use it, mainly for hunting, as the quality of generally affordable hunting gear has dropped dramatically with the rise of cheap, asian made clothing. Yeah you can still buy premium quality stuff that's absolutely brilliant, but for the guy that wants to buy clothing that might get a bit muddy/grimmy/bloody, etc and doesn't want to wear his RM Williams, Rod & Gunn, stuff etc, the quality of generally affordable clothing suitable for such use is woeful IMO.
These days I also tend toward more Blaze Orange hunting clothing as the number of guys deer huntiung, etc is on the rise & I have a distinct dislike for 180gn, 30.06 projectiles whizzing around my ears, or having #4 duck pellets showering me on a swamp.
However, for general hiking, etc where keeping hidden (or attemnpting to) from animal sight isn't an issue I now tend toward more colourful clothing, especially in colder, snowy weather, etc. "All the better to find me with m'dear". If (god forbid) something bad does ever befall me when I'm hiking in the hills, I really don't want the authorities trying in vain to spot me laying in heavy brush wearing full camo stuff.
So, it's good & bad, but a bit o'common sense goes a long way with it also.
Bill.