That looks like a good cup. I don't know if I'd like the teflon added or not, but it does have it's fans.
Carcajou, your cup sounds like a Coleman SS cup. I carry one in my shoulder bag and for as little as it costs, it's a great cup to have on the trail. I've even used it for digging while panning for gold in the Sierra Mtns.
Myself, for water carry when wearing a ruck, I prefer the US issue canteen package w/cover, canteen and canteen cup. Since they all nestle together and hang on a belt, it free's up room in the ruck. Going to add the canteen stove/stand which nestles with the other gear, which will free up my Esbit stoves for smaller kits.